linux-kernel - Re: [PATCH] thermal: cpu_cooling: Fix wrong comment call function name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160908082600.GA3112@e104805>
Date:   Thu, 8 Sep 2016 09:26:00 +0100
From:   Javi Merino <javi.merino@....com>
To:     Inhyuk Kang <hugh.kang@....com>
Cc:     Viresh Kumar <viresh.kumar@...aro.org>, amit.kachhap@...il.com,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        Eduardo Valentin <edubezval@...il.com>,
        Rui Zhang <rui.zhang@...el.com>
Subject: Re: [PATCH] thermal: cpu_cooling: Fix wrong comment call function
 name

On Wed, Sep 07, 2016 at 09:35:39AM +0900, Inhyuk Kang wrote:
> The last_load is updated not cpufreq_get_actual_power() function call
> but cpufreq_get_requested_power() function call.

Yep, my bad.  Thanks for fixing it!

> Signed-off-by: Inhyuk Kang <hugh.kang@....com>

Acked-by: Javi Merino <javi.merino@....com>

> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index a32b417..9ce0e9e 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -74,7 +74,7 @@ struct power_table {
>   *	cpufreq frequencies.
>   * @allowed_cpus: all the cpus involved for this cpufreq_cooling_device.
>   * @node: list_head to link all cpufreq_cooling_device together.
> - * @last_load: load measured by the latest call to cpufreq_get_actual_power()
> + * @last_load: load measured by the latest call to cpufreq_get_requested_power()
>   * @time_in_idle: previous reading of the absolute time that this cpu was idle
>   * @time_in_idle_timestamp: wall time of the last invocation of
>   *	get_cpu_idle_time_us()
> -- 
> 1.9.1
>