linux-kernel - Re: [PATCH v2 6/7] clk: sunxi-ng: Add A23 CCU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGb2v646Qv8biTNP1ryfoLMpt=40i0m9D4EVCFhZ767WkbfwhA@mail.gmail.com>
Date:   Thu, 8 Sep 2016 16:35:04 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Chen-Yu Tsai <wens@...e.org>
Cc:     Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Mike Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Mylene Josserand <mylene.josserand@...e-electrons.com>,
        linux-clk <linux-clk@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Subject: Re: [PATCH v2 6/7] clk: sunxi-ng: Add A23 CCU

On Thu, Sep 8, 2016 at 4:32 PM, Chen-Yu Tsai <wens@...e.org> wrote:
> On Thu, Sep 8, 2016 at 4:29 PM, Maxime Ripard
> <maxime.ripard@...e-electrons.com> wrote:
>> On Wed, Sep 07, 2016 at 03:24:11PM +0800, Chen-Yu Tsai wrote:
>>> > +               [CLK_BUS_MSGBOX]        = &bus_msgbox_clk.common.hw,
>>>
>>> A23 manual and Allwinner sources say there is a bus gate for SPINLOCK.
>>> Tested it myself, and it indeed exists.
>>
>> Yes, sorry. It was supposed to be spinlock instead of msgbox.

There is also a gate for msgbox, in case I'm not clear.

ChenYu

>>
>>> > +       [RST_BUS_SPINLOCK]      =  { 0x2c4, BIT(22) },
>>>
>>> Allwinner sources say there is a reset control for MSGBOX.
>>> Tested it myself, and it indeed exists.
>>
>> However, the msgbox is mentionned nowhere in the datasheet.
>>
>> I'd prefer to be able to test that it actually works before adding it
>> to the clock driver.
>
> I did in fact test it. With reset asserted, writes get ignored,
> and reads produce all 0s. With the reset deasserted and clock
> enabled, reads give the default value and writes stick. Afterwards
> when I toggle the reset, the values revert to the default.
>
> ChenYu