linux-kernel - RE: [PATCH] qede: mark qede_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM5PR11MB172342C66212288F8A5A018697FB0@DM5PR11MB1723.namprd11.prod.outlook.com>
Date:   Thu, 8 Sep 2016 09:02:25 +0000
From:   Yuval Mintz <Yuval.Mintz@...gic.com>
To:     Baoyou Xie <baoyou.xie@...aro.org>
CC:     netdev <netdev@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "xie.baoyou@....com.cn" <xie.baoyou@....com.cn>,
        Ariel Elior <Ariel.Elior@...gic.com>
Subject: RE: [PATCH] qede: mark qede_set_features() static


> We get 1 warning when building kernel with W=1:
> drivers/net/ethernet/qlogic/qede/qede_main.c:2113:5: warning: no previous
> prototype for 'qede_set_features' [-Wmissing-prototypes]
> 
> In fact, this function is only used in the file in which it is declared and don't need
> a declaration, but can be made static.
> so this patch marks this function with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>

Thanks.
Acked-by: Yuval Mintz <Yuval.Mintz@...gic.com>