linux-kernel - Re: [PATCH v2 06/19] remoteproc: core: Add explicit message error if cached table failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aca7b04d-7229-0c85-f9d0-ca81e64feaf6@st.com>
Date:   Thu, 8 Sep 2016 11:40:22 +0200
From:   loic pallardy <loic.pallardy@...com>
To:     Lee Jones <lee.jones@...aro.org>
CC:     <bjorn.andersson@...aro.org>, <ohad@...ery.com>,
        <linux-remoteproc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel@...inux.com>, Loic Pallardy <loic.pallardy@...adoo.fr>
Subject: Re: [PATCH v2 06/19] remoteproc: core: Add explicit message error if
 cached table failed



On 09/01/2016 09:09 AM, Lee Jones wrote:
> On Wed, 31 Aug 2016, Loic Pallardy wrote:
>
>> In rproc_fw_boot, add error message if kmemdump failed
>> as done for other errors.
>>
>> Signed-off-by: Loic Pallardy <loic.pallardy@...adoo.fr>
>> ---
>>  drivers/remoteproc/remoteproc_core.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
>> index 96bc8c644..3282a4e 100644
>> --- a/drivers/remoteproc/remoteproc_core.c
>> +++ b/drivers/remoteproc/remoteproc_core.c
>> @@ -1139,8 +1139,10 @@ static int rproc_fw_boot(struct rproc *rproc, const struct firmware *fw)
>>  	 * cached_table will be copied into device memory.
>>  	 */
>>  	rproc->cached_table = kmemdup(table, tablesz, GFP_KERNEL);
>> -	if (!rproc->cached_table)
>> +	if (!rproc->cached_table) {
>> +		dev_err(dev, "Failed to create cached table\n");
>
> This is an OOM error message, which are not allowed upstream.
>
> I believe if kmemdup() fails, the OOM handler will inform the user.

Yes true, I'll drop this patch in v2
Regards,
Loic
>
>>  		goto clean_up;
>> +	}
>>
>>  	rproc->table_ptr = rproc->cached_table;
>>
>