linux-kernel - Re: powerpc/32: fix again csum_partial_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <3sVFr73rMsz9s3v@ozlabs.org>
Date:   Thu,  8 Sep 2016 19:47:51 +1000 (AEST)
From:   Michael Ellerman <patch-notifications@...erman.id.au>
To:     Christophe Leroy <christophe.leroy@....fr>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Scott Wood <oss@...error.net>
Cc:     Antoine Blangy <antoine.blangy@....fr>,
        Alessio Igor Bogani <alessio.bogani@...ttra.eu>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: powerpc/32: fix again csum_partial_copy_generic()

On Fri, 2016-26-08 at 14:45:13 UTC, Christophe Leroy wrote:
> commit 7aef4136566b0 ("powerpc32: rewrite csum_partial_copy_generic()
> based on copy_tofrom_user()") introduced a bug when destination
> address is odd and len is lower than cacheline size.
> 
> In that case the resulting csum value doesn't have to be rotated one
> byte because the cache-aligned copy part is skipped so no alignment
> is performed.
> 
> Fixes: 7aef4136566b0 ("powerpc32: rewrite csum_partial_copy_generic() based on copy_tofrom_user()")
> Cc: stable@...r.kernel.org
> Reported-by: Alessio Igor Bogani <alessio.bogani@...ttra.eu>
> Signed-off-by: Christophe Leroy <christophe.leroy@....fr>
> Tested-by: Alessio Igor Bogani <alessio.bogani@...ttra.eu>

Applied to powerpc fixes, thanks.

https://git.kernel.org/powerpc/c/8540571e01f973d321b0821f4f

cheers