linux-kernel - RE: [PATCH] Input: wdt87xx_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Sep 2016 01:32:21 -0600
From:   Hn Chen <hn.chen@...dahitech.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:     <linux-input@...r.kernel.org>, lkml <linux-kernel@...r.kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>
Subject: RE: [PATCH] Input: wdt87xx_i2c - support new body WDT8752

Hi Dmitry,

>> Considering to be compatible with i2c-hid, WDT8752 has the same way in 
>> enumerating device.
>If it is a HID device then I think you should write a HID driver for it (unless existing driver, such as hid-multitouch can already handle it, possibly >with some changes). I'm addng Benjamin to he can comment as well.
The device can be handled by i2c-hid driver (HID over I2C) already but this proprietary driver still is a must-have for more features.

>> And also modify the part of FW update to be more efficiency. The main 
>> modification is that reducing the amount of data transmitted and using 
>> polling for time comsuming operation.
>>
>> Flash erase will wait 50ms for the operation complete in last driver.
>> Extend it to 200ms since the spec says the typical is 30ms but the max 
>> is 200ms.
>This should be split into a separate patch please.
Ok, I will resubmit the part of possible-issue fixing and then the driver patch for supporting WDT8752 again.
Please ignore this submission.

Hn.chen