linux-kernel - [PATCH] regulator: da9052: remove null pointer check on array pdata->regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160908100736.19046-1-colin.king@canonical.com>
Date:   Thu,  8 Sep 2016 11:07:36 +0100
From:   Colin King <colin.king@...onical.com>
To:     Support Opensource <support.opensource@...semi.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>
Cc:     linux-kernel@...r.kernel.org
Subject: [PATCH] regulator: da9052: remove null pointer check on array pdata->regulators

From: Colin Ian King <colin.king@...onical.com>

pdata->regulators is an array of DA9052_MAX_REGULATORS struct
regulator_init_data pointers hence cannot be null, so the null pointer
check on pdata->regulators is redundant.  Remove it.

Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 drivers/regulator/da9052-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/da9052-regulator.c b/drivers/regulator/da9052-regulator.c
index 9ececfe..37e4025 100644
--- a/drivers/regulator/da9052-regulator.c
+++ b/drivers/regulator/da9052-regulator.c
@@ -420,7 +420,7 @@ static int da9052_regulator_probe(struct platform_device *pdev)
 	config.dev = &pdev->dev;
 	config.driver_data = regulator;
 	config.regmap = da9052->regmap;
-	if (pdata && pdata->regulators) {
+	if (pdata) {
 		config.init_data = pdata->regulators[cell->id];
 	} else {
 #ifdef CONFIG_OF
-- 
2.9.3