linux-kernel - Re: [PATCH] add Advantech acpi6 hard disk swap button driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160908102446.GB22483@kroah.com>
Date:   Thu, 8 Sep 2016 12:24:46 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Tommy Lo <tommy.lo@...antech.com.tw>
Cc:     arnd@...db.de, linux-kernel@...r.kernel.org,
        oakley.ding@...antech.com.tw
Subject: Re: [PATCH] add Advantech acpi6 hard disk swap button driver

On Wed, Sep 07, 2016 at 09:32:09AM +0000, Tommy Lo wrote:
> Dear Maintainer,
>   This is writing from Advantech , an IPC/Server manufacturer locates in Taiwan. We would like to upstream a hard disk hot swap button driver for Advantech compactPCI products.
> The source code is in the appended document and more precise information is listed as the following. Thanks!
> 
> Information:
> ACPI6-B provide hot-plug button for each SAS HDD, and interrupt (IRQ5) is generated when pressing button or plugging hard disk. The module catches IRQ5, then raises signal to user space application after checking corresponding status register. It also provides ioctl method which response to CPLD to notify LED on/off .  
> The module is developed by Advantech, and follows the Linux code style guidelines to ensure that there aren't any sparse or compile warnings.
> 

Thanks for the patch, but can you resend it with a Signed-off-by: line,
as described by Documentation/SubmittingPatches?  We need that before we
can take anything.

Also, you should run the code through scripts/checkpatch.pl and fix up
the errors it finds.  There are still a number of basic coding style
fixes that need to be done.

And finally, this code really should tie the LED interaction into the
LED kernel subsystem, so that you do not need a custom userspace program
to handle ioctls just for LED control.  Do you need help in making those
changes?

thanks,

greg k-h