linux-kernel - Re: [RFC PATCH] gpio/gpiolib: Forbid irqchip default trigger if probed over DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 8 Sep 2016 14:14:57 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Marc Zyngier <marc.zyngier@....com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH] gpio/gpiolib: Forbid irqchip default trigger if
 probed over DT

On Thu, Sep 08, 2016 at 12:13:27AM +0200, Linus Walleij wrote:
> On Tue, Sep 6, 2016 at 3:59 PM, Marc Zyngier <marc.zyngier@....com> wrote:
> 
> > Using a default trigger is a bad idea if using DT to configure
> > interrupts, as the device's interrupt specifier will always contain
> > the trigger configuration.
> >
> > Let's warn about that particular situation, and revert to not
> > having a default. Hopefully, the couple of drivers still using
> > this feature will quickly be fixed.
> >
> > Signed-off-by: Marc Zyngier <marc.zyngier@....com>
> 
> Patch applied. This is a good way to get rid of this madness.
> 
> > +       /*
> > +        * Specifying a default trigger is a terrible idea if DT is
> > +        * used to configure the interrupts, as you may end-up with
> > +        * conflicting triggers. Tell the user, and reset to NONE.
> > +        */
> > +       if (WARN_ON(of_node && type != IRQ_TYPE_NONE,
> > +                   "%s: Ignoring %d default trigger\n", of_node->full_name))
> > +               type = IRQ_TYPE_NONE;
> 
> I *strongly* suspect this is bad also when using ACPI.

I agree.

> Would the GPIO ACPI people devise a patch on top of this
> to emit the same warning for the ACPI usecase?

Yup, I'll make a patch for ACPI next week.