linux-kernel - Re: [PATCH v5 6/6] gpio: pca953x: make the define names consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1473337655.11323.94.camel@linux.intel.com>
Date:   Thu, 08 Sep 2016 15:27:35 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Alexandre Courbot <gnurou@...il.com>,
        Vignesh R <vigneshr@...com>, Yong Li <yong.b.li@...el.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 6/6] gpio: pca953x: make the define names consistent

On Thu, 2016-09-08 at 12:48 +0200, Bartosz Golaszewski wrote:
> The register offset defines for the pca953x and pca957x expander
> families should have the same names to better reflect their similar
> purposes.



 
>  	chip->regs = &pca957x_regs;
>  
> -	ret = pca953x_read_regs(chip, PCA957X_OUT, chip->reg_output);
> +	ret = pca953x_read_regs(chip, PCA957X_OUTPUT, chip-
> >reg_output);
>  	if (ret)
>  		goto out;
> -	ret = pca953x_read_regs(chip, PCA957X_CFG, chip-
> >reg_direction);
> +	ret = pca953x_read_regs(chip, PCA957X_DIRECTION, chip-
> >reg_direction);

Bu we may use chip->regs->direction here, right? And output before. 

>  	if (ret)
>  		goto out;
>  

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy