linux-kernel - Re: [PATCH v6 1/3] x86/platform/p2sb: New Primary to Sideband bridge support driver for Intel SOC's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 08 Sep 2016 15:35:35 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Tan, Jui Nee" <jui.nee.tan@...el.com>,
        "Gortmaker, Paul (Wind River)" <paul.gortmaker@...driver.com>
Cc:     "mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>,
        "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, X86 ML <x86@...nel.org>,
        "ptyser@...-inc.com" <ptyser@...-inc.com>,
        Lee Jones <lee.jones@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "Yong, Jonathan" <jonathan.yong@...el.com>,
        "Yu, Ong Hock" <ong.hock.yu@...el.com>,
        "Voon, Weifeng" <weifeng.voon@...el.com>,
        "Wan Mohamad, Wan Ahmad Zainie" 
        <wan.ahmad.zainie.wan.mohamad@...el.com>
Subject: Re: [PATCH v6 1/3] x86/platform/p2sb: New Primary to Sideband
 bridge support driver for Intel SOC's

On Mon, 2016-07-18 at 03:35 +0000, Tan, Jui Nee wrote:
> 
> > 
> > +
> > > +MODULE_LICENSE("GPL");
> > 
> > ...the above is the only modular "use" that I can find.  So is the
> > tristate bogus?   Without a module_init and a module_exit I am
> > confused....
> > 
> > I just finished an audit of arch/x86 for bogus uses of module.h so
> > I'd like to
> > ensure we don't add more.

It's a library that can be used as module. My concern is memory
footprint of non-used libraries and modules. I prefer to let module be
tristate until it's proved that it can't be.

> P2SB could be "bool" instead of tristate. 
> My concern is if LPC_ICH built as module and not loaded, P2SB might
> consume memory when P2SB is not being used.
> What do you think? If that's ok for you, my next patch will be
> something like
> this:
> ...
> config P2SB
> 	bool
> 	depends on PCI
> ...
> In p2sb.c, module.h header file will be removed as well.
> Hi Andy, please provide your comments and/or concerns if any. Thanks.


-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy