linux-kernel - Re: [PATCH] drm/tilcdc: mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <84e257f1-3926-1bb3-d791-85709a865886@ti.com>
Date:   Thu, 8 Sep 2016 15:58:05 +0300
From:   Jyri Sarha <jsarha@...com>
To:     Baoyou Xie <baoyou.xie@...aro.org>, <tomi.valkeinen@...com>,
        <airlied@...ux.ie>, <dri-devel@...ts.freedesktop.org>,
        <linux-kernel@...r.kernel.org>, <arnd@...db.de>,
        <xie.baoyou@....com.cn>
Subject: Re: [PATCH] drm/tilcdc: mark symbols static where possible

On 09/08/16 14:29, Baoyou Xie wrote:
> We get 3 warnings when building kernel with W=1:
> drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c:142:29: warning: no previous prototype for 'tilcdc_get_overlay' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c:198:13: warning: no previous prototype for 'tilcdc_convert_slave_node' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c:264:12: warning: no previous prototype for 'tilcdc_slave_compat_init' [-Wmissing-prototypes]
> 
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> So this patch marks these functions with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>

I'll pick this up.
Thanks,
Jyri


> ---
>  drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
> index f9c79da..dd8de260 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
> @@ -139,7 +139,7 @@ static void __init tilcdc_node_disable(struct device_node *node)
>  	of_update_property(node, prop);
>  }
>  
> -struct device_node * __init tilcdc_get_overlay(struct kfree_table *kft)
> +static struct device_node * __init tilcdc_get_overlay(struct kfree_table *kft)
>  {
>  	const int size = __dtb_tilcdc_slave_compat_end -
>  		__dtb_tilcdc_slave_compat_begin;
> @@ -195,7 +195,7 @@ static const char * const tilcdc_slave_props[] __initconst = {
>  	NULL
>  };
>  
> -void __init tilcdc_convert_slave_node(void)
> +static void __init tilcdc_convert_slave_node(void)
>  {
>  	struct device_node *slave = NULL, *lcdc = NULL;
>  	struct device_node *i2c = NULL, *fragment = NULL;
> @@ -261,7 +261,7 @@ out:
>  	of_node_put(fragment);
>  }
>  
> -int __init tilcdc_slave_compat_init(void)
> +static int __init tilcdc_slave_compat_init(void)
>  {
>  	tilcdc_convert_slave_node();
>  	return 0;
>