linux-kernel - Re: [PATCH 5/7] [v2] arm64: dts: add LS1046A-RDB board support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160908131218.GB16911@tiger>
Date:   Thu, 8 Sep 2016 21:12:18 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     shh.xie@...il.com
Cc:     devicetree@...r.kernel.org, robh+dt@...nel.org,
        mark.rutland@....com, linux-arm-kernel@...ts.infradead.org,
        catalin.marinas@....com, will.deacon@....com,
        linux-kernel@...r.kernel.org, arnd@...db.de,
        Mingkai Hu <Mingkai.Hu@....com>,
        Shaohui Xie <Shaohui.Xie@....com>
Subject: Re: [PATCH 5/7] [v2] arm64: dts: add LS1046A-RDB board support

On Mon, Sep 05, 2016 at 06:01:33PM +0800, shh.xie@...il.com wrote:
> +&ifc {
> +	status = "okay";

For sake of consistency, please have 'status' at the end of property
list.

Shawn

> +	#address-cells = <2>;
> +	#size-cells = <1>;
> +	/* NAND Flashe and CPLD on board */
> +	ranges = <0x0 0x0 0x0 0x7e800000 0x00010000
> +		  0x2 0x0 0x0 0x7fb00000 0x00000100>;
> +
> +	nand@0,0 {
> +		compatible = "fsl,ifc-nand";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		reg = <0x0 0x0 0x10000>;
> +	};
> +
> +	cpld: board-control@2,0 {
> +		compatible = "fsl,ls1046ardb-cpld";
> +		reg = <0x2 0x0 0x0000100>;
> +	};
> +};