linux-kernel - Re: [PATCH 3/7] [v2] arm64: dts: add QorIQ LS1046A SoC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160908131818.GF26570@leverpostej>
Date:   Thu, 8 Sep 2016 14:18:18 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     shh.xie@...il.com
Cc:     devicetree@...r.kernel.org, robh+dt@...nel.org,
        linux-arm-kernel@...ts.infradead.org, catalin.marinas@....com,
        will.deacon@....com, shawnguo@...nel.org,
        linux-kernel@...r.kernel.org, arnd@...db.de,
        Mingkai Hu <Mingkai.Hu@....com>,
        Horia Geant? <horia.geanta@....com>,
        Mihai Bantea <mihai.bantea@....com>,
        Chenhui Zhao <chenhui.zhao@....com>,
        Gong Qianyu <Qianyu.Gong@....com>,
        Minghuan Lian <Minghuan.Lian@....com>,
        Hou Zhiqiang <Zhiqiang.Hou@....com>,
        Shaohui Xie <Shaohui.Xie@....com>
Subject: Re: [PATCH 3/7] [v2] arm64: dts: add QorIQ LS1046A SoC support

On Thu, Sep 08, 2016 at 02:13:26PM +0100, Mark Rutland wrote:
> On Mon, Sep 05, 2016 at 06:01:31PM +0800, shh.xie@...il.com wrote:
> > +	cpus {
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		cpu0: cpu@0 {
> > +			device_type = "cpu";
> > +			compatible = "arm,cortex-a72";
> > +			reg = <0x0>;
> > +			clocks = <&clockgen 1 0>;
> > +			next-level-cache = <&l2>;
> > +			cpu-idle-states = <&CPU_PH20>;
> > +		};
> 
> [...]
> 
> > +	};
> > +
> > +	idle-states {
> > +		entry-method = "arm,psci";
> > +
> > +		CPU_PH20: cpu-ph20 {
> > +			compatible = "arm,idle-state";
> > +			idle-state-name = "PH20";
> > +			arm,psci-suspend-param = <0x00010000>;
> > +			entry-latency-us = <1000>;
> > +			exit-latency-us = <1000>;
> > +			min-residency-us = <3000>;
> > +		};
> > +	};
> 
> There's no PSCI node in this file, and none from am included file, so
> this doesn't look right.

Looking again, none of the cpu nodes has an enable-method property, and
subsequent patches don't seem to add that to any cpu node.

Has this DT actually been tested?

Thanks,
Mark.