linux-kernel - Re: [PATCH v10 3/4] ARM64: ACPI: enable ACPI_SPCR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1064bed-3823-392d-e4c1-cf82f06712ff@linaro.org>
Date:   Thu, 8 Sep 2016 21:35:27 +0800
From:   Hanjun Guo <hanjun.guo@...aro.org>
To:     Will Deacon <will.deacon@....com>,
        Aleksey Makarov <amakarov.linux@...il.com>
Cc:     Catalin Marinas <catalin.marinas@....com>,
        Aleksey Makarov <aleksey.makarov@...aro.org>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        "Zheng, Lv" <lv.zheng@...el.com>,
        Kefeng Wang <wangkefeng.wang@...wei.com>,
        Russell King <linux@....linux.org.uk>,
        Peter Hurley <peter@...leysoftware.com>,
        Graeme Gregory <graeme.gregory@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        linux-kernel@...r.kernel.org,
        Leif Lindholm <leif.lindholm@...aro.org>,
        linux-acpi@...r.kernel.org, Yury Norov <ynorov@...iumnetworks.com>,
        Christopher Covington <cov@...eaurora.org>,
        linux-serial@...r.kernel.org, Mark Salter <msalter@...hat.com>,
        Al Stone <ahs3@...hat.com>,
        linux-arm-kernel@...ts.infradead.org, Len Brown <lenb@...nel.org>
Subject: Re: [PATCH v10 3/4] ARM64: ACPI: enable ACPI_SPCR_TABLE

On 2016/9/8 19:16, Will Deacon wrote:
> On Wed, Sep 07, 2016 at 12:30:19PM +0300, Aleksey Makarov wrote:
>>
>> On 09/05/2016 03:36 PM, Aleksey Makarov wrote:
>>> SBBR mentions SPCR as a mandatory ACPI table.  So enable it for ARM64
>>>
>>> Earlycon should be set up as early as possible.  ACPI boot tables are
>>> mapped in arch/arm64/kernel/acpi.c:acpi_boot_table_init() that
>>> is called from setup_arch() and that's where we parse SPCR.
>>> So it has to be opted-in per-arch.
>>>
>>> When ACPI_SPCR_TABLE is defined initialization of DT earlycon is
>>> deferred until the DT/ACPI decision is done.  Initialize DT earlycon
>>> if ACPI is disabled.
>>
>> Hi Will, Catalin,
>>
>> Can you review this patch and consider ACKing it please?
>
> Hanjun, Al, Mark, Graeme -- any comments on this?

We tested this patch on D02, although d02 is 8250 based
uart, but this patch is the core part, which makes sense
to me,

Acked-by: Hanjun Guo <hanjun.guo@...aro.org>

Thanks
Hanjun