[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAMpxmJWdMx2mHN4bWueRAcNMCLGVZr_MkQ2uvpkoBG6MnntgfQ@mail.gmail.com>
Date: Thu, 8 Sep 2016 16:16:19 +0200
From: Bartosz Golaszewski <bgolaszewski@...libre.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Linus Walleij <linus.walleij@...aro.org>,
Alexandre Courbot <gnurou@...il.com>,
Vignesh R <vigneshr@...com>, Yong Li <yong.b.li@...el.com>,
Geert Uytterhoeven <geert+renesas@...der.be>,
linux-gpio <linux-gpio@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 6/6] gpio: pca953x: make the define names consistent
2016-09-08 14:29 GMT+02:00 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>:
> On Thu, 2016-09-08 at 15:27 +0300, Andy Shevchenko wrote:
>> On Thu, 2016-09-08 at 12:48 +0200, Bartosz Golaszewski wrote:
>> >
>> > The register offset defines for the pca953x and pca957x expander
>> > families should have the same names to better reflect their similar
>> > purposes.
>>
>
> And one more question. If it is done in datasheet as is used currently
> in the driver I would leave it to be aligned with official
> documentation.
>
Right, the current names seem to come from the datasheet register
table. I'll drop this patch in v6.
Thanks,
Bartosz
Powered by blists - more mailing lists