linux-kernel - Re: [PATCH] [media] ov9650: add support for asynchronous probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <28493A99-C0CF-4662-B4EF-6D8A3576593D@goldelico.com>
Date:   Thu, 8 Sep 2016 19:08:38 +0200
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     linux-kernel@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Guennadi Liakhovetski <g.liakhovetski@....de>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Hans Verkuil <hans.verkuil@...co.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-media@...r.kernel.org
Subject: Re: [PATCH] [media] ov9650: add support for asynchronous probing


> Am 08.09.2016 um 15:05 schrieb Javier Martinez Canillas <javier@....samsung.com>:
> 
> Allow the sub-device to be probed asynchronously so a bridge driver that's
> waiting for the device can be notified and its .bound callback executed.
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>

Tested-by: hns@...delico.com

> 
> ---
> 
> drivers/media/i2c/ov9650.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c
> index be5a7fd4f076..502c72238a4a 100644
> --- a/drivers/media/i2c/ov9650.c
> +++ b/drivers/media/i2c/ov9650.c
> @@ -23,6 +23,7 @@
> #include <linux/videodev2.h>
> 
> #include <media/media-entity.h>
> +#include <media/v4l2-async.h>
> #include <media/v4l2-ctrls.h>
> #include <media/v4l2-device.h>
> #include <media/v4l2-event.h>
> @@ -1520,6 +1521,10 @@ static int ov965x_probe(struct i2c_client *client,
> 	/* Update exposure time min/max to match frame format */
> 	ov965x_update_exposure_ctrl(ov965x);
> 
> +	ret = v4l2_async_register_subdev(sd);
> +	if (ret < 0)
> +		goto err_ctrls;
> +
> 	return 0;
> err_ctrls:
> 	v4l2_ctrl_handler_free(sd->ctrl_handler);
> @@ -1532,7 +1537,7 @@ static int ov965x_remove(struct i2c_client *client)
> {
> 	struct v4l2_subdev *sd = i2c_get_clientdata(client);
> 
> -	v4l2_device_unregister_subdev(sd);
> +	v4l2_async_unregister_subdev(sd);
> 	v4l2_ctrl_handler_free(sd->ctrl_handler);
> 	media_entity_cleanup(&sd->entity);
> 
> -- 
> 2.7.4
>