linux-kernel - Re: drivers/usb/musb/tusb6010.c:142:21: error: 'USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160908174521.fcrjbcwktfiuujib@atomide.com>
Date:   Thu, 8 Sep 2016 10:45:21 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     kbuild test robot <fengguang.wu@...el.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        Felipe Balbi <balbi@...com>, Bin Liu <b-liu@...com>
Subject: Re: drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared

Hi,

Adding Bin to Cc.

* kbuild test robot <fengguang.wu@...el.com> [160611 13:27]:
> Hi,
> 
> FYI, the error/warning still remains.

Sorry just noticed this going through my inbox.. Please let me know
if there are other pending build errors I may have missed.

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   45b00c94be33db5d00595046663163ce55cbbfb9
> commit: d026e9c76aac3632af174cf02d5c94defa5e6026 usb: musb: Change end point selection to use new IO access
> date:   1 year, 7 months ago
> config: blackfin-allmodconfig (attached as .config)
> compiler: bfin-uclinux-gcc (GCC) 4.6.3
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout d026e9c76aac3632af174cf02d5c94defa5e6026
>         # save the attached .config to linux build tree
>         make.cross ARCH=blackfin 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/usb/musb/tusb6010.c: In function 'tusb_get_revision':
>    drivers/usb/musb/tusb6010.c:53:26: error: 'TUSB_DMA_CTRL_REV' undeclared (first use in this function)

The patch below should fix this, I don't have any blackfin
machines or compilers here to test with though.

Regards,

Tony

8< ---------------------
From: Tony Lindgren <tony@...mide.com>
Date: Thu, 8 Sep 2016 10:36:47 -0700
Subject: [PATCH] usb: musb: Fix tusb6010 compile error on blackfin

We have CONFIG_BLACKFIN ifdef redefining all musb registers in
musb_regs.h and tusb6010.h is never included causing a build
error with blackfin-allmodconfig and COMPILE_TEST.

Let's fix the issue by not building tusb6010 if CONFIG_BLACKFIN
is selected.

Reported-by: kbuild test robot <fengguang.wu@...el.com>
Signed-off-by: Tony Lindgren <tony@...mide.com>

diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
--- a/drivers/usb/musb/Kconfig
+++ b/drivers/usb/musb/Kconfig
@@ -87,7 +87,7 @@ config USB_MUSB_DA8XX
 config USB_MUSB_TUSB6010
 	tristate "TUSB6010"
 	depends on HAS_IOMEM
-	depends on ARCH_OMAP2PLUS || COMPILE_TEST
+	depends on (ARCH_OMAP2PLUS || COMPILE_TEST) && !BLACKFIN
 	depends on NOP_USB_XCEIV = USB_MUSB_HDRC # both built-in or both modules
 
 config USB_MUSB_OMAP2PLUS