[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 09 Sep 2016 11:43:12 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Julia Lawall <Julia.Lawall@...6.fr>
Cc: kernel-janitors@...r.kernel.org,
Hans Verkuil <hans.verkuil@...co.com>,
Antti Palosaari <crope@....fi>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
Hans Verkuil <hverkuil@...all.nl>,
Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
Subject: Re: [PATCH] [media] usb: constify vb2_ops structures
Hi Julia,
Thank you for the patch.
On Friday 09 Sep 2016 01:59:01 Julia Lawall wrote:
> Check for vb2_ops structures that are only stored in the ops field of a
> vb2_queue structure. That field is declared const, so vb2_ops structures
> that have this property can be declared as const also.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct vb2_ops i@p = { ... };
>
> @ok@
> identifier r.i;
> struct vb2_queue e;
> position p;
> @@
> e.ops = &i@p;
>
> @bad@
> position p != {r.p,ok.p};
> identifier r.i;
> struct vb2_ops e;
> @@
> e@i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
> struct vb2_ops i = { ... };
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
For
> drivers/media/usb/uvc/uvc_queue.c | 2 +-
Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists