linux-kernel - Re: [PATCH] EDAC: sb_edac: remove null pointer check on array pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2016 14:50:24 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Colin King <colin.king@...onical.com>,
        Tony Luck <tony.luck@...el.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Doug Thompson <dougthompson@...ssion.com>,
        linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC: sb_edac: remove null pointer check on array pci_tad

+ Tony.

On Thu, Sep 08, 2016 at 09:38:01AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> pvt->pci_tad is a NUM_CHANNELS array of struct pci_dev pointers and
> hence cannot be null, so the pull pointer check on pci_tad is
> redundant.  Remove it.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/edac/sb_edac.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
> index ce0067b..5477522 100644
> --- a/drivers/edac/sb_edac.c
> +++ b/drivers/edac/sb_edac.c
> @@ -2474,7 +2474,7 @@ static int sbridge_mci_bind_devs(struct mem_ctl_info *mci,
>  
>  	/* Check if everything were registered */
>  	if (!pvt->pci_sad0 || !pvt->pci_sad1 || !pvt->pci_ha0 ||
> -	    !pvt-> pci_tad || !pvt->pci_ras  || !pvt->pci_ta)
> +	    !pvt->pci_ras || !pvt->pci_ta)
>  		goto enodev;
>  
>  	if (saw_chan_mask != 0x0f)
> @@ -2563,8 +2563,7 @@ static int ibridge_mci_bind_devs(struct mem_ctl_info *mci,
>  
>  	/* Check if everything were registered */
>  	if (!pvt->pci_sad0 || !pvt->pci_ha0 || !pvt->pci_br0 ||
> -	    !pvt->pci_br1 || !pvt->pci_tad || !pvt->pci_ras  ||
> -	    !pvt->pci_ta)
> +	    !pvt->pci_br1 || !pvt->pci_ras || !pvt->pci_ta)
>  		goto enodev;
>  
>  	if (saw_chan_mask != 0x0f && /* -EN */
> -- 
> 2.9.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-edac" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.