[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 09 Sep 2016 09:15:00 -0700
From: Joe Perches <joe@...ches.com>
To: Jens Axboe <axboe@...com>, Josef Bacik <jbacik@...com>,
linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel-team@...com, mpa@...gutronix.de,
nbd-general@...ts.sourceforge.net
Subject: Re: [PATCH 3/5] nbd: use flags instead of bool
On Fri, 2016-09-09 at 10:11 -0600, Jens Axboe wrote:
> The variable is called 'runtime_flags' - if that doesn't already tell
> the reader how it's used, then I'd suggest the reader go read something
> else.
>
> I'm all for using established APIs where it makes sense. Declaring a
> bitmap for a few fields isn't that.
Deviating from established APIs makes no sense.
Powered by blists - more mailing lists