linux-kernel - Re: [PATCH] ACPICA / Interpreter: Remove redundant newline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2016 21:06:19 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     "Moore, Robert" <robert.moore@...el.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "devel@...ica.org" <devel@...ica.org>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        "Box, David E" <david.e.box@...el.com>
Subject: Re: [PATCH] ACPICA / Interpreter: Remove redundant newline

On Fri, Sep 09, 2016 at 06:45:23PM +0000, Moore, Robert wrote:
> Well, I never thought I would write a couple lines of code like this, but here is a solution that should make everyone happy.
> 
> diff --git a/source/components/tables/tbxfload.c b/source/components/tables/tbxfload.c
> index 6a937b1..73ee1a2 100644
> --- a/source/components/tables/tbxfload.c
> +++ b/source/components/tables/tbxfload.c
> @@ -334,7 +334,7 @@ AcpiTbLoadNamespace (
>      if (!TablesFailed)
>      {
>          ACPI_INFO ((
> -            "%u ACPI AML tables successfully acquired and loaded\n",
> +            "%u ACPI AML tables successfully acquired and loaded",
>              TablesLoaded));
>      }
>      else
> @@ -348,6 +348,11 @@ AcpiTbLoadNamespace (
>          Status = AE_CTRL_TERMINATE;
>      }
>  
> +#ifdef ACPI_APPLICATION
> +    ACPI_DEBUG_PRINT_RAW ((ACPI_DB_INIT, "\n"));
> +#endif
> +
> +
>  UnlockAndExit:
>      (void) AcpiUtReleaseMutex (ACPI_MTX_TABLES);
>      return_ACPI_STATUS (Status);

Works for me. A lot of kernel code does stuff like that already:

$ git grep -E "\(\"\\\n\"\)" | wc -l
1550

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.