linux-kernel - Re: [PATCH 2/9] tty: remove tty_struct dependency in tty flag macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Sep 2016 20:02:40 -0500
From:   Rob Herring <robh@...nel.org>
To:     Alan Cox <alan@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        Peter Hurley <peter@...leysoftware.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>
Subject: Re: [PATCH 2/9] tty: remove tty_struct dependency in tty flag macros

On Fri, Sep 9, 2016 at 5:37 PM, Rob Herring <robh@...nel.org> wrote:
> In preparation to support tty drivers having only a tty_port and
> possibly not a tty_struct, convert all the termios flag macros to take a
> termios ptr instead of the tty_struct ptr. After this change drivers can
> be converted to support a termios struct other than tty->termios.

[...]

> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index 832cbd647145..e5d7e4db6bdc 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -560,7 +560,7 @@ static int at_xdmac_compute_chan_conf(struct dma_chan *chan,
>                         dev_err(chan2dev(chan), "invalid src maxburst value\n");
>                         return -EINVAL;
>                 }
> -               atchan->cfg |= AT_XDMAC_CC_CSIZE(csize);
> +               atchan->cfg |= AT_XDMAC_CC_CSIZE(&csize->termios);
>                 dwidth = ffs(atchan->sconfig.src_addr_width) - 1;
>                 if (dwidth < 0) {
>                         dev_err(chan2dev(chan), "invalid src addr width value\n");
> @@ -583,7 +583,7 @@ static int at_xdmac_compute_chan_conf(struct dma_chan *chan,
>                         dev_err(chan2dev(chan), "invalid src maxburst value\n");
>                         return -EINVAL;
>                 }
> -               atchan->cfg |= AT_XDMAC_CC_CSIZE(csize);
> +               atchan->cfg |= AT_XDMAC_CC_CSIZE(&csize->termios);
>                 dwidth = ffs(atchan->sconfig.dst_addr_width) - 1;
>                 if (dwidth < 0) {
>                         dev_err(chan2dev(chan), "invalid dst addr width value\n");

This file needs to be dropped. There were a few false matches and I
missed this one.

Rob