linux-kernel - Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba60fea2-0a04-c84e-0943-15c8006061ca@rock-chips.com>
Date:   Sat, 10 Sep 2016 17:46:51 +0800
From:   Andy Yan <andy.yan@...k-chips.com>
To:     Heiko Stuebner <heiko@...ech.de>
Cc:     devicetree@...r.kernel.org, briannorris@...omium.org,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        mark.rutland@....com
Subject: Re: [PATCH 1/2] ARM: dts: add rockchip PX3 board

Hi Heiko:


On 2016年09月10日 17:45, Heiko Stuebner wrote:
> Am Samstag, 10. September 2016, 17:37:41 CEST schrieb Andy Yan:
>> Hi Heiko:
>>
>> On 2016年09月10日 17:15, Heiko Stuebner wrote:
>>> Hi Andy,
>>>
>>> Am Samstag, 10. September 2016, 17:01:34 CEST schrieb Andy Yan:
>>>> PX3 board is designed by Rockchip for automotive field,
>>>> which intergrated with CVBS(TP2825)/MIPI DSI/LVDS/HDMI
>>>> video input/output interface, WIFI/BT/GPS(on a module
>>>> named S500 which based on MT6620), Gsensor BMA250E and
>>>> light&proximity sensor STK3410.
>>>>
>>>> Signed-off-by: Andy Yan <andy.yan@...k-chips.com>
>>>> ---
>>>>
>>>>    Documentation/devicetree/bindings/arm/rockchip.txt |   4 +
>>>>    arch/arm/boot/dts/Makefile                         |   1 +
>>>>    arch/arm/boot/dts/rk3188-px3.dts                   | 337
>>>>
>>>> +++++++++++++++++++++ 3 files changed, 342 insertions(+)
>>>>
>>>>    create mode 100644 arch/arm/boot/dts/rk3188-px3.dts
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt
>>>> b/Documentation/devicetree/bindings/arm/rockchip.txt index
>>>> 6668645..e680105
>>>> 100644
>>>> --- a/Documentation/devicetree/bindings/arm/rockchip.txt
>>>> +++ b/Documentation/devicetree/bindings/arm/rockchip.txt
>>>> @@ -21,6 +21,10 @@ Rockchip platforms device tree bindings
>>>>
>>>>        Required root node properties:
>>>>          - compatible = "radxa,rock", "rockchip,rk3188";
>>>>
>>>> +- Rockchip PX3 board:
>>>> +    Required root node properties:
>>>> +      - compatible = "rockchip,px3", "rockchip,rk3188";
>>> Just like to confirm the naming.
>>>
>>> I read the announcement of both the PX3 and PX5 socs, are the boards
>>> really
>>> also named only px3 + px5 - same as the socs they carry, or are they more
>>> likely to be called px3-evb or similar?
>>>
>>> The dts themself look fine on first glance.
>>       We call them px3 or px5 development board in the internal development.
>>       Of course I can change them to px3/px5-evb if you desire.
> I think I would prefer that ... to not confuse socs with boards :-)
> All the other Rockchip devboards are always called evb, so I guess it would be
> the same for the px3+px5 ones.
>
> so I guess the compatible would be
>        - compatible = "rockchip,px3-evb", "rockchip,px3", "rockchip,rk3188";
>

     Okay, I will send a V2 with that
> Heiko
>
>
>