linux-kernel - Re: 584c5c422f6c ("x86/ioapic: Support hot-removal of IOAPICs present during boot")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160910143031.5s4psayo4wqrmpt2@pd.tnic>
Date:   Sat, 10 Sep 2016 16:30:31 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Rui Wang <rui.y.wang@...el.com>
Cc:     bhelgaas@...gle.com, torvalds@...ux-foundation.org,
        peterz@...radead.org, tglx@...utronix.de, helgaas@...nel.org,
        linux-acpi@...r.kernel.org, linux-pci@...r.kernel.org,
        rjw@...ysocki.net, tony.luck@...el.com, mingo@...nel.org,
        x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: 584c5c422f6c ("x86/ioapic: Support hot-removal of IOAPICs
 present during boot")

On Sat, Sep 10, 2016 at 09:11:30PM +0800, Rui Wang wrote:
> Thanks for the analysis. Looks like acpi_gbl_root_node == 0. It is

Is ACPI_HANDLE(root_bus->bridge) == ACPI_ROOT_OBJECT?

Because this is what the code does but I can't see it from the code that
the handle is of type ACPI_ROOT_OBJECT...

> initialized earlier than where we call acpi_ioapic_add().
> start_kernel()
> 	->acpi_early_init()
> 		->acpi_initialize_subsystem()
> 			 ->acpi_ns_root_initialize()
> 				-> acpi_gbl_root_node = ...
> 
> 
> But acpi_gbl_root_node can be 0 if acpi_disabled == 1.
> Do you somehow have acpi turned off (!CONFIG_ACPI or booting with acpi=off)?

Nope.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.