linux-kernel - Re: [PATCH v5 1/3] hwmon: iio_hwmon: defer probe when no channel is found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f335adaf-b670-07f0-9578-b18016c3322d@kernel.org>
Date:   Sat, 10 Sep 2016 16:02:32 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Guenter Roeck <linux@...ck-us.net>,
        Quentin Schulz <quentin.schulz@...e-electrons.com>,
        jdelvare@...e.com, knaack.h@....de, lars@...afoo.de,
        pmeerw@...erw.net, maxime.ripard@...e-electrons.com, wens@...e.org,
        lee.jones@...aro.org
Cc:     thomas.petazzoni@...e-electrons.com,
        antoine.tenart@...e-electrons.com, linux-kernel@...r.kernel.org,
        linux-hwmon@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 1/3] hwmon: iio_hwmon: defer probe when no channel is
 found

On 09/09/16 05:26, Guenter Roeck wrote:
> On 09/08/2016 07:28 AM, Quentin Schulz wrote:
>> iio_channel_get_all returns -ENODEV when it cannot find either phandles and
>> properties in the Device Tree or channels whose consumer_dev_name matches
>> iio_hwmon in iio_map_list. The iio_map_list is filled in by iio drivers
>> which might be probed after iio_hwmon.
>>
>> It is better to defer the probe of iio_hwmon if such error is returned by
>> iio_channel_get_all in order to let a chance to iio drivers to expose
>> channels in iio_map_list.
>>
>> Signed-off-by: Quentin Schulz <quentin.schulz@...e-electrons.com>
>> ---
>>
>> v5:
>>  - patch re-inserted,
>>
> Grumble ... applied to -next anyway.
> 
> I'll direct any complaints your way ;-)
> 
> Guenter
> 
Thanks.  I'll try and squeeze some time to look at a more general
solution (reworking how we set the maps up in the first place) if
no one else gets to it first!

It's on the list :)

Jonathan