linux-kernel - Re: [PATCH] x86/ioapic: Ignore root bridges without a companion ACPI device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160910172724.fayvcuapvadjbpsd@pd.tnic>
Date:   Sat, 10 Sep 2016 19:27:24 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Rui Wang <rui.y.wang@...el.com>
Cc:     bhelgaas@...gle.com, tglx@...utronix.de, rjw@...ysocki.net,
        mingo@...nel.org, torvalds@...ux-foundation.org,
        peterz@...radead.org, helgaas@...nel.org,
        linux-acpi@...r.kernel.org, linux-pci@...r.kernel.org,
        tony.luck@...el.com, x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/ioapic: Ignore root bridges without a companion ACPI
 device

On Sat, Sep 10, 2016 at 11:40:45PM +0800, Rui Wang wrote:
> Some PCI root bridges don't have a corresponding ACPI device.
> This can be the case on some old platforms. Don't call acpi_ioapic_add()
> on these bridges because they can't support ioapic hotplug.
> 
> v2: Per Boris's review, removed the unnecessary local var; refined comment
> 
> Signed-off-by: Rui Wang <rui.y.wang@...el.com>
> Reviewed-by: Borislav Petkov <bp@...en8.de>
>
> ---
>  drivers/pci/setup-bus.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
> index ec538d3..8b4e231 100644
> --- a/drivers/pci/setup-bus.c
> +++ b/drivers/pci/setup-bus.c
> @@ -1855,7 +1855,10 @@ void __init pci_assign_unassigned_resources(void)
>  
>  	list_for_each_entry(root_bus, &pci_root_buses, node) {
>  		pci_assign_unassigned_root_bus_resources(root_bus);
> -		acpi_ioapic_add(ACPI_HANDLE(root_bus->bridge));
> +
> +		/* make sure the root bridge has a companion ACPI device */
> +		if (ACPI_HANDLE(root_bus->bridge))
> +			acpi_ioapic_add(ACPI_HANDLE(root_bus->bridge));

Reported-and-tested-by: Borislav Petkov <bp@...e.de>

Thanks Rui!

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.