linux-kernel - Re: [PATCH] extcon: Introduce EXTCON_PROP_DISP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2efb2c01-b85a-bbd9-f803-29aabe3b1844@roeck-us.net>
Date:   Fri, 9 Sep 2016 20:07:40 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Chris Zhong <zyw@...k-chips.com>, myungjoo.ham@...sung.com,
        cw00.choi@...sung.com
Cc:     linux-kernel@...r.kernel.org, cpgs@...sung.com, groeck@...omium.org
Subject: Re: [PATCH] extcon: Introduce EXTCON_PROP_DISP_HPD property

On 09/09/2016 05:33 PM, Chris Zhong wrote:
> EXTCON_PROP_DISP_HPD is need by display port, if the system has no hpd
> interrupt, this property can be used.
>
> Change-Id: I8b3eb78429126eaa369b10711b7f857b0a3df8ed

Drop Change-ID: for upstream submissions.

> Signed-off-by: Chris Zhong <zyw@...k-chips.com>

Otherwise, yes, looks like this is needed.

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  include/linux/extcon.h | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/extcon.h b/include/linux/extcon.h
> index 9147c42..4411893 100644
> --- a/include/linux/extcon.h
> +++ b/include/linux/extcon.h
> @@ -131,9 +131,21 @@
>  #define EXTCON_PROP_JACK_MAX		100
>  #define EXTCON_PROP_JACK_CNT (EXTCON_PROP_JACK_MAX - EXTCON_PROP_JACK_MIN + 1)
>
> +/*
> + * Properties of EXTCON_TYPE_DISP.
> + *
> + * - EXTCON_PROP_DISP_HPD
> + * @type:       integer (intval)
> + * @value:      0 (no hpd) or 1 (hpd)
> + * @default:    0 (no hpd)
> + *
> + */
> +
> +#define EXTCON_PROP_DISP_HPD		150
> +
>  /* Properties of EXTCON_TYPE_DISP. */
>  #define EXTCON_PROP_DISP_MIN		150
> -#define EXTCON_PROP_DISP_MAX		150
> +#define EXTCON_PROP_DISP_MAX		151
>  #define EXTCON_PROP_DISP_CNT (EXTCON_PROP_DISP_MAX - EXTCON_PROP_DISP_MIN + 1)
>
>  /*
>