linux-kernel - Re: [PATCH v1 1/2] usb: gadget: u_ether: fix another dereference after null check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 10 Sep 2016 11:39:53 +0800
From:   Peter Chen <hzpeterchen@...il.com>
To:     Harish Jenny K N <harish_kandiga@...tor.com>
Cc:     Felipe Balbi <balbi@...nel.org>, linux-usb@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, Jim Baxter <jim_baxter@...tor.com>
Subject: Re: [PATCH v1 1/2] usb: gadget: u_ether: fix another dereference
 after null check

On Fri, Sep 09, 2016 at 11:30:41AM +0200, Harish Jenny K N wrote:
> dev->port_usb is checked for null pointer previously, so dev->port_usb
> might be null during no zlp check, fix it by adding null pointer check.
> 
> Acked-by: Jim Baxter <jim_baxter@...tor.com>
> Signed-off-by: Harish Jenny K N <harish_kandiga@...tor.com>
> ---
>  drivers/usb/gadget/function/u_ether.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c
> index 3be4b93..9c8c9ed 100644
> --- a/drivers/usb/gadget/function/u_ether.c
> +++ b/drivers/usb/gadget/function/u_ether.c
> @@ -571,7 +571,8 @@ static netdev_tx_t eth_start_xmit(struct sk_buff *skb,
>  	req->complete = tx_complete;
>  
>  	/* NCM requires no zlp if transfer is dwNtbInMaxSize */
> -	if (dev->port_usb->is_fixed &&
> +	if (dev->port_usb &&
> +	    dev->port_usb->is_fixed &&
>  	    length == dev->port_usb->fixed_in_len &&
>  	    (length % in->maxpacket) == 0)
>  		req->zero = 0;

Acked-by: Peter Chen <peter.chen@....com>

-- 

Best Regards,
Peter Chen