[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.20.1609100807300.9305@nanos>
Date: Sat, 10 Sep 2016 08:10:59 +0200 (CEST)
From: Thomas Gleixner <tglx@...utronix.de>
To: Mark Brown <broonie@...nel.org>
cc: Binoy Jayan <binoy.jayan@...aro.org>,
Carsten Emde <C.Emde@...dl.org>,
"Steven Rostedt (Red Hat)" <rostedt@...dmis.org>,
Ingo Molnar <mingo@...hat.com>,
Daniel Wagner <daniel.wagner@...-carit.de>,
Arnd Bergmann <arnd@...db.de>,
Linux kernel mailing list <linux-kernel@...r.kernel.org>,
Masami <masami.hiramatsu@...aro.org>
Subject: Re: [PATCH v6 4/4] tracing: Histogram for delayed hrtimer offsets
On Fri, 9 Sep 2016, Mark Brown wrote:
> On Thu, Sep 08, 2016 at 03:09:36PM +0530, Binoy Jayan wrote:
> > On 8 September 2016 at 12:40, Thomas Gleixner <tglx@...utronix.de> wrote:
> > > On Wed, 7 Sep 2016, Binoy Jayan wrote:
>
> > >> +#ifdef CONFIG_DELAYED_TIMER_OFFSETS_HIST
> > >> + ktime_t praecox;
> > >> +#endif
>
> > > And of course documenting new struct members is optional, correct? I'm
> > > really looking forward for the explanation of that variable name.
>
> > It marks the start time when a process is scheduled to be woken up as
> > the result
> > of expiry of the hrtimer. Will be mentioning it in the comments.
>
> Even with an appropriate comment I'm not sure that the term praecox is
> sufficiently widely understood to be a clear variable name.
For those who understand it and know the main use case of this term it
certainly has entertainment value.
Thanks,
tglx
Powered by blists - more mailing lists