linux-kernel - Re: [PATCH 9/9] tty: serial_core: add tty NULL check in uart_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160911222043.50848f95@lxorguk.ukuu.org.uk>
Date:   Sun, 11 Sep 2016 22:20:43 +0100
From:   One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
To:     Rob Herring <robh@...nel.org>
Cc:     Alan Cox <alan@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        Peter Hurley <peter@...leysoftware.com>,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH 9/9] tty: serial_core: add tty NULL check in
 uart_port_startup

On Fri,  9 Sep 2016 17:37:10 -0500
Rob Herring <robh@...nel.org> wrote:

> If we don't have a tty when calling uart_port_startup, skip the baudrate
> and modem control setup which depend on tty->termios struct. Either
> tty_port clients will configure the line in a separate call or we'll
> move termios into the tty_port.

I don't think getting rid of the tty object makes any sense whatsoever
just create a kernel one.

Either way the giant churny patch and this hack should be deferred in
favour of moving the termios structure into the tty port (and the locks
for it) and doing the right job once.

The termios does I agree belong in the tty_port so irrespective of final
direction fixing that is a right move.

Alan