linux-kernel - Re: [BISECTED REGRESSION] v4.8-rc: gpio-leds broken on OCTEON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160911221346.GA1658@raspberrypi.musicnaut.iki.fi>
Date:   Mon, 12 Sep 2016 01:13:46 +0300
From:   Aaro Koskinen <aaro.koskinen@....fi>
To:     Thorsten Leemhuis <regressions@...mhuis.info>
Cc:     "Steven J. Hill" <Steven.Hill@...ium.com>,
        David Daney <ddaney@...iumnetworks.com>,
        Jon Hunter <jonathanh@...dia.com>,
        Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org,
        linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org
Subject: Re: [BISECTED REGRESSION] v4.8-rc: gpio-leds broken on OCTEON

Hi,

On Sun, Sep 11, 2016 at 02:41:39PM +0200, Thorsten Leemhuis wrote:
> Hi! On 25.08.2016 20:24, Aaro Koskinen wrote:
> > On Wed, Aug 24, 2016 at 11:42:00AM -0500, Steven J. Hill wrote:
> >> It is actually two patches that cause the breakage. The other is:
> >>    commit e55aeb6ba4e8cc3549bff1e75ea1d029324bce21
> >>    of/irq: Mark interrupt controllers as populated before initialisation
> >> I needed to revert both of these in order to get MMC working on our 71xx and
> >> 78xx boards. For our MMC, I got error messages from the MMC core of "Invalid
> >> POWER GPIO" until I applied the second patch. I will have a fix worthy of
> >> upstreaming today which will be posted today.
> > 
> > The below change works for me...
> > 
> > diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c
> > index 5a9b87b..5fd57c2 100644
> > --- a/arch/mips/cavium-octeon/octeon-irq.c
> > +++ b/arch/mips/cavium-octeon/octeon-irq.c
> > @@ -1618,6 +1618,7 @@ static int __init octeon_irq_init_gpio(
> >  		pr_warn("Cannot allocate memory for GPIO irq_domain.\n");
> >  		return -ENOMEM;
> >  	}
> > +	of_node_clear_flag(gpio_node, OF_POPULATED);
> >  
> >  	return 0;
> >  }
> 
> This afaics wasn't merged and the discussion looks stalled. Was this
> issue discussed elsewhere or even fixed in between? Just asking, because
> this issue is on the list of regressions for 4.8.

There's a patch waiting to be merged in Linux MIPS patchwork:

	https://patchwork.linux-mips.org/patch/14091/

A.