lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 11 Sep 2016 15:19:00 +0300 From: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com> To: Peter Huewe <peterhuewe@....de> Cc: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>, Marcel Selhorst <tpmdd@...horst.net>, Jason Gunthorpe <jgunthorpe@...idianresearch.com>, tpmdd-devel@...ts.sourceforge.net (moderated list:TPM DEVICE DRIVER), linux-kernel@...r.kernel.org (open list) Subject: [PATCH] tpm: fix buffer overflow in /dev/tpm0 tpm_write() does not check whether the buffer has at least enough space for the header before passing it to tpm_transmit() so an overflow can happen. Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com> --- drivers/char/tpm/tpm-interface.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c index fd863ff..6a67f7f 100644 --- a/drivers/char/tpm/tpm-interface.c +++ b/drivers/char/tpm/tpm-interface.c @@ -337,6 +337,9 @@ ssize_t tpm_transmit(struct tpm_chip *chip, const u8 *buf, size_t bufsiz, u32 count, ordinal; unsigned long stop; + if (bufsiz < TPM_HEADER_SIZE) + return -EINVAL; + if (bufsiz > TPM_BUFSIZE) bufsiz = TPM_BUFSIZE; -- 2.7.4
Powered by blists - more mailing lists