linux-kernel - Re: [PATCH v4 03/22] usb: ulpi: Support device discovery via DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <147371790115.20135.5378574586724662470@sboyd-linaro>
Date:   Mon, 12 Sep 2016 15:05:01 -0700
From:   Stephen Boyd <stephen.boyd@...aro.org>
To:     linux-usb@...r.kernel.org,
        "Heikki Krogerus" <heikki.krogerus@...ux.intel.com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org,
        "Andy Gross" <andy.gross@...aro.org>,
        "Bjorn Andersson" <bjorn.andersson@...aro.org>,
        "Neil Armstrong" <narmstrong@...libre.com>,
        "Arnd Bergmann" <arnd@...db.de>, "Felipe Balbi" <balbi@...nel.org>,
        "Peter Chen" <peter.chen@....com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        devicetree@...r.kernel.org, "Rob Herring" <robh+dt@...nel.org>
Subject: Re: [PATCH v4 03/22] usb: ulpi: Support device discovery via DT

Quoting Stephen Boyd (2016-09-07 14:35:00)
> @@ -174,6 +219,21 @@ static int ulpi_register(struct device *dev, struct ulpi *ulpi)
>         ulpi->id.product = ulpi_read(ulpi, ULPI_PRODUCT_ID_LOW);
>         ulpi->id.product |= ulpi_read(ulpi, ULPI_PRODUCT_ID_HIGH) << 8;
>  
> +       /* Some ULPI devices don't have a vendor id so rely on OF match */
> +       if (ulpi->id.vendor == 0)
> +               goto err;
> +
> +       request_module("ulpi:v%04xp%04x", ulpi->id.vendor, ulpi->id.product);
> +
> +       return 0;
> +err:
> +       return of_device_request_module(&ulpi->dev);

This can't return the value of of_device_request_module() because that
returns an error if the module is builtin or if module loading is
disabled. I'll have to ignore the error here and just return success all
the time.