linux-kernel - Re: [PATCH v3] mmc: sdhci-msm: Add pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANYu_0tviS8tiG1Zskk2XHnXQ=7CJKH_gcCaUOoT+kMh-2oTCQ@mail.gmail.com>
Date:   Mon, 12 Sep 2016 13:17:07 +0530
From:   Pramod Gurav <pramod.gurav@...aro.org>
To:     "Tummala, Sahitya" <stummala@...eaurora.org>
Cc:     linux-mmc <linux-mmc@...r.kernel.org>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH v3] mmc: sdhci-msm: Add pm_runtime and system PM support

On 9 September 2016 at 15:30, Tummala, Sahitya <stummala@...eaurora.org> wrote:
> Hi Pramod,
<snip>
>> +       ret = clk_prepare_enable(msm_host->clk);
>> +       if (ret) {
>> +               dev_err(dev, "clk_enable failed: %d\n", ret);
>
> A minor comment - Both error prints related to clock enable are same. Better
> to print the clock name as well to know which clock enable got failed.
>

Thanks Sahitya for comments. Will take care of this in next version.
>> +               return ret;
>> +       }