linux-kernel - Re: [PATCH -next] drm/tilcdc: Fix non static symbol warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Sep 2016 11:24:47 +0300
From:   Jyri Sarha <jsarha@...com>
To:     Wei Yongjun <weiyj.lk@...il.com>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        David Airlie <airlied@...ux.ie>
CC:     Wei Yongjun <weiyongjun1@...wei.com>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] drm/tilcdc: Fix non static symbol warning

On 09/10/16 15:32, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@...wei.com>
> 
> Fixes the following sparse warning:
> 
> drivers/gpu/drm/tilcdc/tilcdc_drv.c:64:5: warning:
>  symbol 'tilcdc_atomic_check' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

I'll pick this up.

Thanks,
Jyri

> ---
>  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 4405e4b..dc58770 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -61,8 +61,8 @@ static void tilcdc_fb_output_poll_changed(struct drm_device *dev)
>  	drm_fbdev_cma_hotplug_event(priv->fbdev);
>  }
>  
> -int tilcdc_atomic_check(struct drm_device *dev,
> -			struct drm_atomic_state *state)
> +static int tilcdc_atomic_check(struct drm_device *dev,
> +			       struct drm_atomic_state *state)
>  {
>  	int ret;
>  
> 
> 
>