linux-kernel - Re: [PATCH v3 0/3] spi-nor: Add support for Intel SPI serial flash controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160912083537.GA1811@lahna.fi.intel.com>
Date:   Mon, 12 Sep 2016 11:35:37 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Lee Jones <lee.jones@...aro.org>,
        David Woodhouse <dwmw2@...radead.org>
Cc:     Brian Norris <computersforpeace@...il.com>,
        linux-mtd@...ts.infradead.org, Peter Tyser <ptyser@...-inc.com>,
        key.seong.lim@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/3] spi-nor: Add support for Intel SPI serial flash
 controller

On Tue, Aug 30, 2016 at 11:47:43AM +0100, Lee Jones wrote:
> On Tue, 30 Aug 2016, Mika Westerberg wrote:
> 
> > On Tue, Aug 30, 2016 at 10:13:30AM +0100, Lee Jones wrote:
> > > On Mon, 29 Aug 2016, Mika Westerberg wrote:
> > > 
> > > > On Mon, Aug 15, 2016 at 10:10:41AM +0300, Mika Westerberg wrote:
> > > > > Hi,
> > > > > 
> > > > > This is third version of the series. Previous versions can be found:
> > > > > 
> > > > >   v2: http://lists.infradead.org/pipermail/linux-mtd/2016-June/068277.html
> > > > >   v1: https://lkml.org/lkml/2016/6/14/269
> > > > > 
> > > > > This series adds support for the Intel SPI serial flash controller found on
> > > > > many recent Intel CPUs including Baytrail and Braswell. This driver makes
> > > > > it possible to access the BIOS and other platform data which is stored on
> > > > > the SPI serial flash. It is also possible to upgrade the BIOS using this
> > > > > driver if it has not been protected by special hardware bits.
> > > > > 
> > > > > The patch [1/3] includes documentation how to upgrade BIOS on MinnowBoard
> > > > > MAX.
> > > > > 
> > > > > Since poking the SPI serial flash can brick the machine, this driver can
> > > > > only be enabled when CONFIG_EXPERT=y and even then it will remain read-only
> > > > > unless instructed othwerwise by module parameter.
> > > > > 
> > > > > Lee can you ACK/NACK the MFD parts so that we can merge the whole series
> > > > > through the MTD tree?
> > > 
> > > Why does it need to go into the MTD tree?  What are the *build*
> > > dependencies?
> > 
> > The first patch adds include/linux/platform_data/intel-spi.h which is
> > needed by the second patch to fill in the platform data structure.
> 
> That's reasonable.
> 
> I'm happy for the set to be routed via MTD.  I do require a tagged
> immutable branch (with only these patches on) to pull from though.

Hmm, still nothing from Brian and we are already in -rc6.

David, you are also listed as MTD maintainer would you be able pick the
driver up to your linux-mtd tree and provide Lee an immutable branch?