linux-kernel - Re: [PATCH] staging/android: mark sync_timeline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20160912094545.GA20335@kroah.com>
Date:   Mon, 12 Sep 2016 11:45:45 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     Sudip Mukherjee <sudipm.mukherjee@...il.com>, arve@...roid.com,
        riandrews@...roid.com, devel@...verdev.osuosl.org,
        xie.baoyou@....com.cn,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] staging/android: mark sync_timeline_create() static

On Mon, Sep 05, 2016 at 08:40:25AM +0800, Baoyou Xie wrote:
> 
> 
> On 4 September 2016 at 23:41, Sudip Mukherjee <sudipm.mukherjee@...il.com>
> wrote:
> 
>     On Sat, Sep 03, 2016 at 02:34:13PM +0800, Baoyou Xie wrote:
>     > We get 1 warning when building kernel with W=1:
>     > drivers/staging/android/sw_sync.c:56:23: warning: no previous prototype
>     for 'sync_timeline_create' [-Wmissing-prototypes]
>     >
>     > In fact, this function is only used in the file in which it is
>     > declared and don't need a declaration, but can be made static.
>     > so this patch marks this function with 'static'.
>     >
>     > Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
>     > ---
>     >  drivers/staging/android/sw_sync.c | 2 +-
>     >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>     which tree are you using?
> 
> 
> I using master tree with 4.8-rc1

That's a quick way to ensure that your patches will not apply, as that
tree does not contain any of the patches submitted since then.

Please always work against linux-next or my staging-next tree for
staging patches.

thanks,

greg k-h