linux-kernel - Re: [PATCH] drivers/edac: NO_IRQ removal from powerpc-only drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871t0pqw3s.fsf@concordia.ellerman.id.au>
Date:   Mon, 12 Sep 2016 19:57:11 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Borislav Petkov <bp@...en8.de>, dougthompson@...ssion.com,
        mchehab@...nel.org, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org
Subject: Re: [PATCH] drivers/edac: NO_IRQ removal from powerpc-only drivers

Arnd Bergmann <arnd@...db.de> writes:

> On Monday, September 12, 2016 2:47:37 PM CEST Michael Ellerman wrote:
>> >> @@ -1058,7 +1058,7 @@ static int mpc85xx_mc_err_probe(struct platform_device *op)
>> >>  
>> >>      pdata = mci->pvt_info;
>> >>      pdata->name = "mpc85xx_mc_err";
>> >> -    pdata->irq = NO_IRQ;
>> >> +    pdata->irq = 0;
>> >>      mci->pdev = &op->dev;
>> >>      pdata->edac_idx = edac_mc_idx++;
>> >>      dev_set_drvdata(mci->pdev, mci);
>> >
>> > That part went into drivers/edac/fsl_ddr_edac.c which is only the
>> > freescale memory controller being shared between ARM and PPC, see
>> >
>> > http://git.kernel.org/cgit/linux/kernel/git/bp/bp.git/log/?h=for-next
>> >
>> > But that shouldn't change the issue wrt ->irq as now it is implicitly 0.
>> 
>> Ah OK.
>> 
>> NO_IRQ is -1 on ARM (or at least it can be?), see arch/arm/include/asm/irq.h.
>> 
>> So I'll leave that one alone for now.
>
> I don't think there is any way to build the mpc85xx on ARM, it depends
> on the powerpc-specific "FSL_SOC" symbol and it uses the in_be32/out_be32
> MMIO helpers that are not defined on ARM.

Yeah you're right. The common code between powerpc and arm64 is in
fsl_ddr_edac.c, not mpc85xx_edac.c. There are no uses of NO_IRQ

Will send a v2 with all uses removed from drivers/edac.

cheers