linux-kernel - Re: [PATCH] x86/xen: add missing \n at end of printk warning message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5fd35560-c017-3f1f-016f-932e4796b83e@suse.com>
Date:   Mon, 12 Sep 2016 13:31:07 +0200
From:   Juergen Gross <jgross@...e.com>
To:     Colin King <colin.king@...onical.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        David Vrabel <david.vrabel@...rix.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        xen-devel@...ts.xenproject.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/xen: add missing \n at end of printk warning message

On 12/09/16 12:20, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The message is missing a \n, add it.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Juergen Gross <jgross@...e.com>

> ---
>  arch/x86/xen/platform-pci-unplug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/xen/platform-pci-unplug.c b/arch/x86/xen/platform-pci-unplug.c
> index d37a0c7..90d1b83 100644
> --- a/arch/x86/xen/platform-pci-unplug.c
> +++ b/arch/x86/xen/platform-pci-unplug.c
> @@ -61,7 +61,7 @@ static int check_platform_magic(void)
>  		}
>  		break;
>  	default:
> -		printk(KERN_WARNING "Xen Platform PCI: unknown I/O protocol version");
> +		printk(KERN_WARNING "Xen Platform PCI: unknown I/O protocol version\n");
>  		return XEN_PLATFORM_ERR_PROTOCOL;
>  	}
>  
>