linux-kernel - Re: [PATCH 14/26] spi: dw-pci: constify local structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1609121400350.3049@hadrien>
Date:   Mon, 12 Sep 2016 14:01:49 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Mark Brown <broonie@...nel.org>
cc:     joe@...ches.com, kernel-janitors@...r.kernel.org,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/26] spi: dw-pci: constify local structures



On Sun, 11 Sep 2016, Julia Lawall wrote:

> For structure types defined in the same file or local header files, find
> top-level static structure declarations that have the following
> properties:
> 1. Never reassigned.
> 2. Address never taken
> 3. Not passed to a top-level macro call
> 4. No pointer or array-typed field passed to a function or stored in a
> variable.
> Declare structures having all of these properties as const.

Please ignore this patch.  The file contains eg

{ PCI_VDEVICE(INTEL, 0x0800), (kernel_ulong_t)&spi_pci_mid_desc_1}

which Coccinelle was incorrectly interpreting as a bit and operation, due
to not realizing that kernel_ulong_t is a type.

julia

> Done using Coccinelle.
> Based on a suggestion by Joe Perches <joe@...ches.com>.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
>
> ---
> The semantic patch seems too long for a commit log, but is in the cover
> letter.
>
>  drivers/spi/spi-dw-pci.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-dw-pci.c b/drivers/spi/spi-dw-pci.c
> index ef7db75..60198a3 100644
> --- a/drivers/spi/spi-dw-pci.c
> +++ b/drivers/spi/spi-dw-pci.c
> @@ -29,13 +29,13 @@ struct spi_pci_desc {
>  	u16	bus_num;
>  };
>
> -static struct spi_pci_desc spi_pci_mid_desc_1 = {
> +static const struct spi_pci_desc spi_pci_mid_desc_1 = {
>  	.setup = dw_spi_mid_init,
>  	.num_cs = 5,
>  	.bus_num = 0,
>  };
>
> -static struct spi_pci_desc spi_pci_mid_desc_2 = {
> +static const struct spi_pci_desc spi_pci_mid_desc_2 = {
>  	.setup = dw_spi_mid_init,
>  	.num_cs = 2,
>  	.bus_num = 1,
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>