linux-kernel - Re: [PATCH for-next 09/20] IB/hns: Optimize code of aeq and ceq interrupt handle and fix the bug of qpn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160912123255.GG8812@leon.nu>
Date:   Mon, 12 Sep 2016 15:32:55 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Salil Mehta <salil.mehta@...wei.com>
Cc:     dledford@...hat.com, xavier.huwei@...wei.com, oulijun@...wei.com,
        yisen.zhuang@...wei.com, xuwei5@...ilicon.com,
        mehta.salil.lnk@...il.com, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com
Subject: Re: [PATCH for-next 09/20] IB/hns: Optimize code of aeq and ceq
 interrupt handle and fix the bug of qpn

On Fri, Sep 09, 2016 at 06:30:40PM +0800, Salil Mehta wrote:

....

> +			     HNS_ROCE_AEQE_EVENT_QP_EVENT_QP_QPN_M,
> +			     HNS_ROCE_AEQE_EVENT_QP_EVENT_QP_QPN_S);
> +	phy_port = roce_get_field(aeqe->event.qp_event.qp,
> +			HNS_ROCE_AEQE_EVENT_QP_EVENT_PORT_NUM_M,
> +			HNS_ROCE_AEQE_EVENT_QP_EVENT_PORT_NUM_S);
> +	if (qpn <= 1)
> +		qpn = HNS_ROCE_MAX_PORTS * qpn + phy_port;
> +
> +	switch (event_type) {
> +	case HNS_ROCE_EVENT_TYPE_INV_REQ_LOCAL_WQ_ERROR:
> +		dev_warn(dev, "Invalid Req Local Work Queue Error.\n");
> +		dev_warn(dev, "QP %d, phy_port %d.\n", qpn, phy_port);

dev_warn like all other printk flavours supports multi-line messages.

> +		break;

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)