linux-kernel - Re: [PATCH] tracing/hwlat: select TRACER_MAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160912100311.581ec811@gandalf.local.home>
Date:   Mon, 12 Sep 2016 10:03:11 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH] tracing/hwlat: select TRACER_MAX_TRACE

On Wed,  7 Sep 2016 18:08:31 +0200
Arnd Bergmann <arnd@...db.de> wrote:

> hwlat_trace cannot work without CONFIG_TRACER_MAX_TRACE:
> 
> kernel/trace/trace_hwlat.c: In function 'get_sample':
> kernel/trace/trace_hwlat.c:258:18: error: 'struct trace_array' has no member named 'max_latency'; did you mean 'max_lock'?
>    if (sample > tr->max_latency)
>                   ^~
> kernel/trace/trace_hwlat.c:259:6: error: 'struct trace_array' has no member named 'max_latency'; did you mean 'max_lock'?
>     tr->max_latency = sample;
>       ^~
> kernel/trace/trace_hwlat.c: In function 'hwlat_tracer_init':
> kernel/trace/trace_hwlat.c:583:4: error: 'struct trace_array' has no member named 'max_latency'; did you mean 'max_lock'?
>   tr->max_latency = 0;
> 
> We also have to enable CONFIG_TRACER_SNAPSHOT, which in turn
> is a dependency of CONFIG_TRACER_MAX_TRACE.

Hi Arnd,

Thanks.

Randy Dunlap already reported this, and it's been fixed. I just
finished testing and it will be uploaded today. The real fix was posted
in the thread here:

http://lkml.kernel.org/r/d6c3b7eb-ba95-1ffa-0453-464e1e24262a@infradead.org

-- Steve