linux-kernel - Use of schedule() function while holding a lock in ql4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <57D63AC7.9010507@oracle.com>
Date:   Mon, 12 Sep 2016 10:49:03 +0530
From:   Vaishali Thakkar <vaishali.thakkar@...cle.com>
To:     QLogic-Storage-Upstream@...gic.com,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Use of schedule() function while holding a lock in ql4_nx.c

Hello,

I was wondering about the call to schedule in function qla4_82xx_crb_win_lock for driver
drivers/scsi/qla4xxx/ql4_nx.c. It is called in 2 functions [qla4_82xx_rd_32 and
qla4_82xx_wr_32] while holding a write_lock_irqsave. Normally we avoid using sleeping
functions while holding a lock.

Is there some reason that I am overlooking? Why it is OK in this case? Are we using
schedule() here intentionally?

Thank you.

-- 
Vaishali