linux-kernel - RE: [PATCH] regulator: da9055: remove null pointer check on array pdata->regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Sep 2016 16:09:49 +0000
From:   Steve Twiss <stwiss.opensource@...semi.com>
To:     Colin King <colin.king@...onical.com>,
        Support Opensource <Support.Opensource@...semi.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        "Mark Brown" <broonie@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] regulator: da9055: remove null pointer check on array
 pdata->regulators




On 08 September 2016 10:47, Colin King wrote:

> To: Support Opensource; Liam Girdwood; Mark Brown
> Cc: linux-kernel@...r.kernel.org
> Subject: [PATCH] regulator: da9055: remove null pointer check on array pdata->regulators
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> pdata->regulators is an array of DA9052_MAX_REGULATORS struct
> regulator_init_data pointers hence cannot be null, so the null pointer
> check on pdata->regulators is redundant.  Remove it.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/regulator/da9055-regulator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/da9055-regulator.c b/drivers/regulator/da9055-
> regulator.c
> index d029c94..a118f63 100644
> --- a/drivers/regulator/da9055-regulator.c
> +++ b/drivers/regulator/da9055-regulator.c
> @@ -612,7 +612,7 @@ static int da9055_regulator_probe(struct
> platform_device *pdev)
>  	config.driver_data = regulator;
>  	config.regmap = da9055->regmap;
> 
> -	if (pdata && pdata->regulators) {
> +	if (pdata) {
>  		config.init_data = pdata->regulators[pdev->id];
>  	} else {
>  		ret = da9055_regulator_dt_init(pdev, regulator, &config,
> --
> 2.9.3

Yes, it's true. 

One my colleagues just pointed out why they had déjà vu.

May  I refer to the answer that was given back in March,
https://patchwork.kernel.org/patch/8679771/

Regards,
Steve