linux-kernel - Re: [PATCH] skd: fix assert typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x49r38pj9o7.fsf@segfault.boston.devel.redhat.com>
Date:   Mon, 12 Sep 2016 13:43:36 -0400
From:   Jeff Moyer <jmoyer@...hat.com>
To:     Eric Engestrom <eric.engestrom@...tec.com>
Cc:     <linux-kernel@...r.kernel.org>, Jens Axboe <axboe@...com>,
        Ming Lin <ming.l@....samsung.com>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        Hannes Reinecke <hare@...e.com>,
        Mike Christie <mchristi@...hat.com>,
        Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCH] skd: fix assert typo

Eric Engestrom <eric.engestrom@...tec.com> writes:

> Signed-off-by: Eric Engestrom <eric.engestrom@...tec.com>
> ---
>  drivers/block/skd_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
> index 3822eae..94a7425 100644
> --- a/drivers/block/skd_main.c
> +++ b/drivers/block/skd_main.c
> @@ -1905,7 +1905,7 @@ static void skd_send_internal_skspcl(struct skd_device *skdev,
>  		break;
>  
>  	default:
> -		SKD_ASSERT("Don't know what to send");
> +		SKD_ASSERT(!"Don't know what to send");

That's perverse.  Just change SKD_ASSERT to pr_err and Robert's your
mother's brother.

Cheers,
Jeff