linux-kernel - Re: [PATCH 6/7] perf ui/tui: Reset output width for hierarchy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160913010117.GD3641@sejong>
Date:   Tue, 13 Sep 2016 10:01:17 +0900
From:   Namhyung Kim <namhyung@...nel.org>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Jiri Olsa <jolsa@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH 6/7] perf ui/tui: Reset output width for hierarchy

On Mon, Sep 12, 2016 at 11:27:47AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Sep 12, 2016 at 03:19:57PM +0900, Namhyung Kim escreveu:
> > When --hierarchy option is used, each entry has its own hpp_list to show
> > the result.  But it missed to update width of each column.
> 
> Ditto, missing "Fixes:" tag.

It's the same commit.  Will add the tag.

Thanks,
Namhyung


>  
> > Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> > ---
> >  tools/perf/ui/browsers/hists.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
> > index 35e44b1879e3..49db16334814 100644
> > --- a/tools/perf/ui/browsers/hists.c
> > +++ b/tools/perf/ui/browsers/hists.c
> > @@ -2067,6 +2067,7 @@ void hist_browser__init(struct hist_browser *browser,
> >  			struct hists *hists)
> >  {
> >  	struct perf_hpp_fmt *fmt;
> > +	struct perf_hpp_list_node *node;
> >  
> >  	browser->hists			= hists;
> >  	browser->b.refresh		= hist_browser__refresh;
> > @@ -2079,6 +2080,11 @@ void hist_browser__init(struct hist_browser *browser,
> >  		perf_hpp__reset_width(fmt, hists);
> >  		++browser->b.columns;
> >  	}
> > +	/* hierarchy entries have their own hpp list */
> > +	list_for_each_entry(node, &hists->hpp_formats, list) {
> > +		perf_hpp_list__for_each_format(&node->hpp, fmt)
> > +			perf_hpp__reset_width(fmt, hists);
> > +	}
> >  }
> >  
> >  struct hist_browser *hist_browser__new(struct hists *hists)
> > -- 
> > 2.9.3