linux-kernel - Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1609130926080.3355@hadrien>
Date:   Tue, 13 Sep 2016 09:27:11 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Namrata A Shettar <namrataashettar@...il.com>
cc:     Ian Abbott <abbotti@....co.uk>, hsweeten@...ionengravers.com,
        gregkh@...uxfoundation.org, badbuddha91@...il.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia:
 Removes unnecessary blank line



On Tue, 13 Sep 2016, Namrata A Shettar wrote:

> This patch removes an unnecessary blank line that caused checkpatch issue.

Actually, commit messages and subject lines should be written in the
imperative.  So you should say eg

Remove unnecessary blank line

instead of

Removes unnecessary blank line

julia

>
> Signed-off-by: Namrata A Shettar <namrataashettar@...il.com>
> ---
> Changes in v2:
>   - Changed the subject line
>   - Changed description of patch
>
>  drivers/staging/comedi/comedi_pcmcia.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_pcmcia.c
> b/drivers/staging/comedi/comedi_pcmcia.c
> index d7072a5..ec8a0ad 100644
> --- a/drivers/staging/comedi/comedi_pcmcia.c
> +++ b/drivers/staging/comedi/comedi_pcmcia.c
> @@ -18,7 +18,6 @@
>
>  #include <linux/module.h>
>  #include <linux/kernel.h>
> -
>  #include "comedi_pcmcia.h"
>
>  /**
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@...glegroups.com.
> To post to this group, send email to outreachy-kernel@...glegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAFrQyDErWX1NgsruZtt10hi
> hZR2J3cvK-Q9Zj_dp_GLc_0mLmA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>