linux-kernel - Re: [PATCH v2 0/4] ARM: amlogic: Add spifc support to Amlogic's GXBB family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Sep 2016 10:03:27 +0200
From:   jbrunet <jbrunet@...libre.com>
To:     Kevin Hilman <khilman@...libre.com>
Cc:     Carlo Caione <carlo@...one.org>, linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/4] ARM: amlogic: Add spifc support to Amlogic's
 GXBB family

On Mon, 2016-09-12 at 13:38 -0700, Kevin Hilman wrote:
> Jerome Brunet <jbrunet@...libre.com> writes:
> 
> > 
> > This patch series adds the necessary pins, clocks and device tree
> > nodes to
> > enable the spifc controller on the GXBB family. I had to add the
> > nand pins
> > in pintctrl as the pinmux setting left by u-boot was conflicting
> > with the
> > spifc pinmux during my test on the P200.
> 
> This series seems to be missing a patch which enables the SPIfc on
> the
> P200 board for use with the on-board NOR flash.
> 
> Kevin
> 

Indeed, I did not provide this patch, on purpose.
The SPI-NOR at 4U2 on the P200 schematics was not present on the board
I have. I assumed this was the case for all other P200 as well.

In addition, to enable the SPI-NOR, you would also need to solder
something at 4R3 (SPI_CS signal disconnected by default)

Finally, all the SPIfc lines are shared with the NAND controller which,
like the SPI-NOR, appears on the schematics (4CCN1) but is not soldered
on the actual hardware.

Of course, I can share such patch for testing purposes if you would
like me to.

Jerome.

> > 
> > Changes since v1 at : http://lkml.kernel.org/r/1473261223-15412-1-g
> > it-send-email-jbrunet@...libre.com
> >  * Omit patches :
> >   - dt-bindings: spi-meson: Add GXBB Compatible string
> >   - spi: meson: Add GXBB compatible
> >   Sent as dedicated series
> >  * Omit patch:
> >   - clk: gxbb: expose spifc clock
> >   Already applied
> >  * Rename SPI flash controller pins from spifc_* to nor_* to keep
> > the
> >    name aligned with the datasheet
> > 
> > Jerome Brunet (3):
> >   pinctrl: amlogic: gxbb: add spi nor pins
> >   pinctrl: amlogic: gxbb: add nand pins
> >   ARM64: dts: amlogic: add spi nor pins
> > 
> > Neil Armstrong (1):
> >   ARM64: dts: meson-gxbb: Add SPIFC node
> > 
> >  arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 19 +++++++++++++++
> >  drivers/pinctrl/meson/pinctrl-meson-gxbb.c  | 37
> > +++++++++++++++++++++++++++++
> >  2 files changed, 56 insertions(+)