linux-kernel - Re: [patch v1] x86/platform/mellanox: introduce support for Mellanox systems platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160913081212.GA15715@kroah.com>
Date:   Tue, 13 Sep 2016 10:12:12 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Vadim Pasternak <vadimp@...lanox.com>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        "jiri@...nulli.us" <jiri@...nulli.us>
Subject: Re: [patch v1] x86/platform/mellanox: introduce support for Mellanox
 systems platform

On Tue, Sep 13, 2016 at 07:27:20AM +0000, Vadim Pasternak wrote:
> 
> 
> > -----Original Message-----
> > From: Ingo Molnar [mailto:mingo.kernel.org@...il.com] On Behalf Of Ingo
> > Molnar
> > Sent: Monday, September 12, 2016 2:01 PM
> > To: Greg KH <gregkh@...uxfoundation.org>
> > Cc: Geert Uytterhoeven <geert@...ux-m68k.org>; Vadim Pasternak
> > <vadimp@...lanox.com>; tglx@...utronix.de; mingo@...hat.com;
> > hpa@...or.com; davem@...emloft.net; akpm@...ux-foundation.org;
> > kvalo@...eaurora.org; mchehab@...nel.org; linux@...ck-us.net;
> > x86@...nel.org; linux-kernel@...r.kernel.org; platform-driver-
> > x86@...r.kernel.org; jiri@...nulli.us
> > Subject: Re: [patch v1] x86/platform/mellanox: introduce support for Mellanox
> > systems platform
> > 
> > 
> > * Greg KH <gregkh@...uxfoundation.org> wrote:
> > 
> > > On Mon, Sep 12, 2016 at 11:14:26AM +0200, Geert Uytterhoeven wrote:
> > > > On Mon, Sep 12, 2016 at 10:34 AM, Greg KH <gregkh@...uxfoundation.org>
> > wrote:
> > > > >> This is LPC to I2C bridge.
> > > > >
> > > > > "LPC"?
> > > >
> > > > https://en.wikipedia.org/wiki/Low_Pin_Count
> > > >
> > > > "Modern ISA"
> > >
> > > So my original point stands, 1990's technology being used for brand
> > > new devices today, ugh :(
> > >
> > > Someone needs to go kick some hardware designers...
> > 
> > In their defense, "this is a carbon copy of published 1990s technology" is a pretty
> > good starting point for a defendant, in patent litigation.
> > 
> 
> I understood your comments regarding undiscoverable busses.
> But we use LPC on all our x86 based systems.
> I have to activate all platform related stuff from some place and we
> don't support ACPI.

x86 that doesn't support ACPI?  That's sad :(

> Do you think it would be OK, if I'll remove all PCI related code, make
> use of DMI and leave only platform activation code?
> If yes, I'll re-work this driver and re-send it for your review.

Yes, that sounds like a good start, let's see how the code looks after
doing that.

thanks,

greg k-h